fix: support cluster creation/scale with NodePort and TLS enabled #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivebyer
requested review from
iamabhishek-dubey and
shubham-cmyk
as code owners
drivebyer
changed the title
drivebyer
changed the title
drivebyer
changed the title
drivebyer
force-pushed
the
nodeport-scale
branch
from
d237849 to
de67f1d
Compare
When using the NodePort service type, `redis-cli --cluster create node-ip:nodeport`
and `redis-cli --cluster add-node node-ip:nodeport` are used.
Added support for `cluster-announce-tls-port` when both TLS and NodePort are enabled.
Signed-off-by: drivebyer <[email protected]>
drivebyer
force-pushed
the
nodeport-scale
branch
from
de67f1d to
eb90b5a
Compare
Signed-off-by: drivebyer <[email protected]>
naimadswdn
pushed a commit
to naimadswdn/redis-operator
that referenced
this pull request
Oct 23, 2025
Redis cluster creation was failing silently due to empty endpoint values being added to Redis CLI commands after [PR 1568](OT-CONTAINER-KIT#1568) merge. Scope: - Validate getEndpoint() returns non-empty values before using them - Return errors from createRedisReplicationCommand when endpoints fail - Prevents silent failures in cluster bootstrap process
4 tasks
naimadswdn
pushed a commit
to naimadswdn/redis-operator
that referenced
this pull request
Oct 23, 2025
Redis cluster creation was failing silently due to empty endpoint values being added to Redis CLI commands after [PR 1568](OT-CONTAINER-KIT#1568) merge. Scope: - Validate getEndpoint() returns non-empty values before using them - Return errors from createRedisReplicationCommand when endpoints fail - Prevents silent failures in cluster bootstrap process Signed-off-by: Damian Seredyn <[email protected]>
Contributor
|
@drivebyer I think there was a small bug implemented in that PR, resulting in empty endpoints being added to Redis CLI commands. |
naimadswdn
pushed a commit
to naimadswdn/redis-operator
that referenced
this pull request
Oct 28, 2025
Redis cluster creation was failing silently due to empty endpoint values being added to Redis CLI commands after [PR 1568](OT-CONTAINER-KIT#1568) merge. Scope: - Validate getEndpoint() returns non-empty values before using them - Return errors from createRedisReplicationCommand when endpoints fail - Prevents silent failures in cluster bootstrap process Signed-off-by: Damian Seredyn <[email protected]>
drivebyer
pushed a commit
to naimadswdn/redis-operator
that referenced
this pull request
Oct 29, 2025
Redis cluster creation was failing silently due to empty endpoint values being added to Redis CLI commands after [PR 1568](OT-CONTAINER-KIT#1568) merge. Scope: - Validate getEndpoint() returns non-empty values before using them - Return errors from createRedisReplicationCommand when endpoints fail - Prevents silent failures in cluster bootstrap process Signed-off-by: Damian Seredyn <[email protected]>
drivebyer
pushed a commit
to naimadswdn/redis-operator
that referenced
this pull request
Nov 4, 2025
Redis cluster creation was failing silently due to empty endpoint values being added to Redis CLI commands after [PR 1568](OT-CONTAINER-KIT#1568) merge. Scope: - Validate getEndpoint() returns non-empty values before using them - Return errors from createRedisReplicationCommand when endpoints fail - Prevents silent failures in cluster bootstrap process Signed-off-by: Damian Seredyn <[email protected]>
naimadswdn
pushed a commit
to naimadswdn/redis-operator
that referenced
this pull request
Nov 4, 2025
Redis cluster creation was failing silently due to empty endpoint values being added to Redis CLI commands after [PR 1568](OT-CONTAINER-KIT#1568) merge. Scope: - Validate getEndpoint() returns non-empty values before using them - Return errors from createRedisReplicationCommand when endpoints fail - Prevents silent failures in cluster bootstrap process Signed-off-by: Damian Seredyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redis-cli --cluster create node-ip:nodeportandredis-cli --cluster add-node node-ip:nodeportare used.cluster-announce-tls-portwhen both TLS and NodePort are enabled.Description
Type of change
Checklist
Additional Context